Developers of Sympa

[Guillaume Rousse <address@concealed>]

Le 12/03/2013 11:55, Marc Chantreux a écrit :
> On Thu, Mar 07, 2013 at 05:02:37PM +0100, Guillaume Rousse wrote:
> > - I'm still unable to figure out how Sympa::PlainDigest module
> > works, as this kind of invocation is plain chinese for me:
> > msg->{'plain_body'} = $mail->Sympa::PlainDigest::plain_body_as_string();
>
> this is a namespace shortcutting: you can read it as
>
>      msg->{'plain_body'} =
>          Sympa::PlainDigest::plain_body_as_string $mail;
>
> do you want me to investigate this part of the code ?
Yes, I think we need some cleanup here.

The whole idea of calling a method of a class on a object which is not 
an instance of this class is ugly. We should probably turn it into a 
simple formatting function, somewhere under Sympa::Tools::Something 
namespace.

--
Guillaume Rousse
INRIA, Direction des systèmes d'information
Domaine de Voluceau
Rocquencourt - BP 105
78153 Le Chesnay
Tel: 01 39 63 58 31

Attachment: smime.p7s
Description: Signature cryptographique S/MIME