Developers of Sympa

[IKEDA Soji <address@concealed>]

Guillaume,

On Mon, 18 Mar 2013 09:57:48 +0100
Guillaume Rousse <address@concealed> wrote:

> Le 13/03/2013 12:22, IKEDA Soji a écrit :
> > Would you like to make up .perltidyrc not far from your formatting
> > rules?
> This seems to be the closest match.
> 
> However, it does far more than just fixing indentation, which is my main 
> grief against this kind of tools. For instance, it turns human-crafted 
> constructs such as
> $foo->bar({
>    param1 => value1,
>    param2 => value2
> });
> into an additional useless indentation step:
> $foo->bar(
>    {
>      param1 => value1,
>      param2 => value2
>    }
> );

I've realized it, too.  perltidy seems to hate LISPishness :-/.

Other examples will be found such as:

    unless (
        SDM::do_query(
            q{...},
            $arg
        )
        ) {
        ...;
    }

> My point is just than perltidy is just one way to help achieving desired 
> result, not the the desired result itself.

If the result is not very curious, it may be acceptable for me.

So, ---

As you are working on sympa-cleanup branch, single hash arguments
need not be hash references.  Similarly, my example may be rewritten as:

    unless (
        SDM::do_query q{...},
            $arg
    ) {
        ...;
    }

or

    $sth = SDM::do_query(
        q{...},
        $arg
    );
    unless ($sth) {
        ...;
    }

I feel they are easier to read even without reformatting.

My answer might not be what you want...


Regards,

--- Soji

-- 
株式会社 コンバージョン  セキュリティ&OSSソリューション部   池田荘児
〒231-0004　神奈川県横浜市中区元浜町3-21-2 ヘリオス関内ビル7F
e-mail address@concealed  TEL 045-640-3550
http://www.conversion.co.jp/
-- 
株式会社 コンバージョン  セキュリティ&OSSソリューション部   池田荘児
〒231-0004　神奈川県横浜市中区元浜町3-21-2 ヘリオス関内ビル7F
e-mail address@concealed  TEL 045-640-3550
http://www.conversion.co.jp/