The mailing list for listmasters using Sympa

[Mark Duling <address@concealed>]

Title: Re: [sympa-users] Define multiple editors-moderators in family

Mark,

I missed that ICONSDIR is no longer used since 5.4.  So that means that to fix DESTDIR support, all that is needed is this patch:
--- wwsympa/Makefile.orig    2008-01-30 09:10:56.000000000 -0800
+++ wwsympa/Makefile    2009-02-11 15:28:26.000000000 -0800
@@ -100,8 +100,8 @@
 
 installicons:
     @echo "Installing icons..."
-    @echo $(DIR)/static_content/icons
-    cp icons/*.png $(DIR)/static_content/icons
+    @echo $(DESTDIR)$(DIR)/static_content/icons
+    cp icons/*.png $(DESTDIR)$(DIR)/static_content/icons
 
 installwrapper:
     @echo "Installing wwsympa-wrapper binary..."

Because there must be a DESTDIR to match the one in the top-level Makefile that creates the directory, otherwise when using DESTDIR the cp command will try to copy the files to a non-existent path.

installdir:
    @echo "Creating required directories"
    @for dir in $(DIR) $(EXPL_DIR) $(CONFDIR) $(SAMPLEDIR) $(ETCDIR) $(BINDIR) $(LOCALEDIR) $(DOCDIR) $(DIR)/static_content $(DIR)/static_content/icons ; do \
        if [ ! -d $(DESTDIR)$$dir ] ; then \
            echo "Creating $(DESTDIR)$$dir"; \
            mkdir -p $(DESTDIR)$$dir; \
            chown $(USER) $(DESTDIR)$$dir; \
            chgrp $(GROUP) $(DESTDIR)$$dir; \
            chmod 755 $(DESTDIR)$$dir; \
        fi \

If this patch could be applied to the next release that would be great.  I’ll paste the same info in ticket #5815.  But I don’t understand why ICONSDIR support was dropped.  The path $(DIR)/static_content/icons seems awkward to me.  It is awkward for most package managers I think.

Thanks!

Mark


On 2/9/09 9:42 AM, "Mark Duling" <address@concealed> wrote:

> Hi Mark,
>
> I am referring to release 5.4.5.  I am on the MacPorts team, and MacPorts depends on DESTDIR to work because it directs ‘make install’ to install files to an intermediate location before putting them in their final location.  If DESTDIR is to be supported by an application’s install routine, it must be supported in all aspects.  Otherwise, during ‘make install’ some files are installed in one location, and some in another at the very least.  Now if you don’t set DESTDIR (as you normally don’t for generic manual installs), everything is installed in the same location.  I suspect that is what you did when you installed it.  But I do set DESTDIR (as I must with MacPorts), and I see the problem.
>
> So for example, when doing the MacPorts install of sympa-5.4.5, the install location is:
>
> /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_mail_sympa/work/destroot/opt/local/......
>
> But when it gets to icons, it trys to install it in:
>
> /opt/local/static_content/icons
>
> But that is an entirely different location since DESTDIR is not used in the icon installation routine.  Further, directory for icons was created in a part of the Makefile that did respect DESTDIR so ‘cp icons/*.png $(DIR)/static_content/icons’ tries to install to a directory that doesn’t exist because DESTDIR is not used in the icon routine as I mentioned.
>
> Below is the log info.  But if you don’t set DESTDIR, you’ll never see the problem.  I also created bug #5815 on this.  Thanks for asking.  I hope that explains the problem better.
>
> Mark
>
>
>
> Creating required directories
> Creating /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_mail_sympa/work/destroot/opt/local/var/sympa/expl
> Creating /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_mail_sympa/work/destroot/opt/local/etc/sympa
> Creating /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_mail_sympa/work/destroot/opt/local/share/sympa/sample
> Creating /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_mail_sympa/work/destroot/opt/local/bin/sympa
> Creating /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_mail_sympa/work/destroot/opt/local/share/locale
> Creating /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_mail_sympa/work/destroot/opt/local/share/doc/sympa
> Creating /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_mail_sympa/work/destroot/opt/local/static_content
> Creating /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_mail_sympa/work/destroot/opt/local/static_content/icons
>
> [...trimmed output ...]
>
> Installing icons...
> /opt/local/static_content/icons
> cp icons/*.png /opt/local/static_content/icons
> usage: cp [-R [-H | -L | -P]] [-fi | -n] [-pvX] source_file target_file
>        cp [-R [-H | -L | -P]] [-fi | -n] [-pvX] source_file ... target_directory
> make[1]: *** [installicons] Error 64
> make: *** [installwws] Error 1
>
>
>
>
>
>
>
> On 2/9/09 7:32 AM, "David Verdin" <address@concealed> wrote:
>
> > Hi Mark,
> >
> > I tried it with the latest trunk development version available and the
> > 5.4.5 version and it worked just fine (with the same data you provided
> > in your mail).
> > What version do you use?
> >
> > Regards,
> >
> > Mark Sallee a écrit :
> > > Ok, I figured this out by simply adding these editors manually to the
> > > family's config.tt2 - leaving out all the fancy variables.
> > >
> > > editor
> > > reception mail
> > > email address@concealed
> > > visibility conceal
> > >
> > > editor
> > > reception mail
> > > email address@concealed
> > > visibility conceal
> > >
> > > editor
> > > reception mail
> > > email address@concealed
> > > visibility conceal
> > >
> > > and then was able to re-instantiate the family, passing on these
> > > settings to all 50 lists.
> > >
> > > Issue closed.
> > >
> > >
> > > -------------------------------------------------------------
> > > original message:
> > > How can we add multiple editors to a family configuration and then
> > > reinstantiate the family?
> > > Documentation says to try this in .xml file for multiple owners:
> > >
> > > <snip>
> > >
> > > In the config.tt2 for the family:
> > >
> > > [% IF moderator %]
> > >   [% FOREACH m = moderator %]
> > > editor
> > >   email [% m.email %]
> > >   [% END %]
> > > [% END %]
> > >
> > > Then ran this command to duplicate the settings across the family:
> > > sympa.pl --instantiate_family partners-xx --robot domain.edu --input_file
> > > /home/sympa/etc/families/partners-xx/partners-fam.xml
> > >
> > > But it gives the error:
> > >
> > > List::_load_admin_file() Bad entry "  email
> > > " in paragraph "email" in editor
> > >
> > > Suggestions?
> > >
> > > Mark Sallee
> > >
> > >  
> >
> > --
> > David Verdin
> > Comité réseau des universités