Developers of Sympa

[Marc Chantreux <address@concealed>]

On Thu, Sep 27, 2018 at 10:21:49AM +0900, IKEDA Soji wrote:
> At first, before you begin modifying code, you would be better to read
> the code carefully.
> I suggest you should put your immediate target to write test cases.
> To accomplish it, you have to read and unserstand the code.

that was the process:

* read the code carrefully
* write a test when the expected behavior is obvious
* refactor

i read the code and saw this regexp and i'm trying to figure out
why you wrote this in such a weird way.

as i was afraid of writing a bad test because i missed something,
i write the test i sent asking for more details.

so i do exactly what you are telling me to do but writting tests
for those modules needs to have a clear understanding of the behavior.
I can't be in your brain, you let no clue and i have to figure out
reading the code.

can you provide examples where your regex do the magic trick compared to
mine? it's not a contest: it's a way for me to understand what you
wrote (that's what i call "read carrefully").

> (Maybe you chose Sympa::Bulk because it comes the beginning in
> alphabetical order.)

    vim $( find . -type '*.pm' |sed $[RANDOM % 10]q )

marc