Developers of Sympa

[IKEDA Soji <address@concealed>]

Hi Guillaume, David and folks,

On Tue, 06 Nov 2012 16:35:10 +0100
David Verdin <address@concealed> wrote:
> Le 06/11/12 16:11, Guillaume Rousse a écrit :
> > Le 06/11/2012 15:36, address@concealed a écrit :
> >> +    ## Compatibility: $robot may be a string
> >> +    unless (ref $robot) {
> >> +    if ($robot and $robot ne '*') {
> >> +        $robot = Robot->new($robot);
> >> +    }
> > Backward compatibility desirability is quite discussable here. I'd 
> > personally would prefer to trace back any part of the code calling 
> > this function, and fixing them once for all, but that may me 
> > considered a bit invasive :)
> >
> > Can we aim to a compromise, and keep this part, but with a deprecation 
> > warning ? Somrthing in the line of
> > carp "deprecated usage: robot parameter should be a Robot object";
> Looks good to me. This way, we would have a good start at generalizing 
> the usage of Robot object, but it would leave us time to track parts of 
> the code using the robot name only.

It's in sense.  I'll carp obsoleted robot usage.  In practice,
switching to OO robot is too big work to be done by myself.

I'll celanup my branch in this weekend, then it can be merged
(It will contain the switching from global %Conf hash to Site
accessors).

Thanks for precise advices!


--- Soji

> > David: could you change the default reply-to for the sympa-commits 
> > list to sympa-developpers, instead of no-reply ? Thanks.
> Done, my good sir. ;)
> 
> 


-- 
株式会社 コンバージョン  セキュリティ&OSSソリューション部   池田荘児
〒231-0004　神奈川県横浜市中区元浜町3-21-2 ヘリオス関内ビル7F
e-mail address@concealed  TEL 045-640-3550
http://www.conversion.co.jp/