Skip to Content.
Sympa Menu

devel - Re: [sympa-developpers] [sympa-commits] sympa[7915] branches/db_list_cache: [dev] Commands.pm, Scenario.pm, report. pm: Modified to be based on objective Robot.

Subject: Developers of Sympa

List archive

Chronological Thread  
  • From: David Verdin <address@concealed>
  • To: address@concealed
  • Subject: Re: [sympa-developpers] [sympa-commits] sympa[7915] branches/db_list_cache: [dev] Commands.pm, Scenario.pm, report. pm: Modified to be based on objective Robot.
  • Date: Tue, 06 Nov 2012 16:35:10 +0100


Le 06/11/12 16:11, Guillaume Rousse a écrit :
Le 06/11/2012 15:36, address@concealed a écrit :
+ ## Compatibility: $robot may be a string
+ unless (ref $robot) {
+ if ($robot and $robot ne '*') {
+ $robot = Robot->new($robot);
+ }
Backward compatibility desirability is quite discussable here. I'd personally would prefer to trace back any part of the code calling this function, and fixing them once for all, but that may me considered a bit invasive :)

Can we aim to a compromise, and keep this part, but with a deprecation warning ? Somrthing in the line of
carp "deprecated usage: robot parameter should be a Robot object";
Looks good to me. This way, we would have a good start at generalizing the usage of Robot object, but it would leave us time to track parts of the code using the robot name only.

David: could you change the default reply-to for the sympa-commits list to sympa-developpers, instead of no-reply ? Thanks.
Done, my good sir. ;)


Attachment: smime.p7s
Description: Signature cryptographique S/MIME




Archive powered by MHonArc 2.6.19+.

Top of Page