Subject: Developers of Sympa
List archive
Re: [sympa-developpers] [sympa-commits] sympa[7915] branches/db_list_cache: [dev] Commands.pm, Scenario.pm, report. pm: Modified to be based on objective Robot.
- From: Guillaume Rousse <address@concealed>
- To: address@concealed
- Subject: Re: [sympa-developpers] [sympa-commits] sympa[7915] branches/db_list_cache: [dev] Commands.pm, Scenario.pm, report. pm: Modified to be based on objective Robot.
- Date: Tue, 06 Nov 2012 16:11:37 +0100
Le 06/11/2012 15:36, address@concealed a écrit :
+ ## Compatibility: $robot may be a stringBackward compatibility desirability is quite discussable here. I'd personally would prefer to trace back any part of the code calling this function, and fixing them once for all, but that may me considered a bit invasive :)
+ unless (ref $robot) {
+ if ($robot and $robot ne '*') {
+ $robot = Robot->new($robot);
+ }
Can we aim to a compromise, and keep this part, but with a deprecation warning ? Somrthing in the line of
carp "deprecated usage: robot parameter should be a Robot object";
David: could you change the default reply-to for the sympa-commits list to sympa-developpers, instead of no-reply ? Thanks.
--
Guillaume Rousse
INRIA, Direction des systèmes d'information
Domaine de Voluceau
Rocquencourt - BP 105
78153 Le Chesnay
Tel: 01 39 63 58 31
Attachment:
smime.p7s
Description: Signature cryptographique S/MIME
- Re: [sympa-developpers] [sympa-commits] sympa[7915] branches/db_list_cache: [dev] Commands.pm, Scenario.pm, report. pm: Modified to be based on objective Robot., Guillaume Rousse, 11/06/2012
Archive powered by MHonArc 2.6.19+.