Developers of Sympa

[Guillaume Rousse <address@concealed>]

Le 08/11/2012 14:44, address@concealed a écrit :
> Revision
>     7924
> Author
>     sikeda
> Date
>     2012-11-08 14:44:31 +0100 (jeu. 08 nov. 2012)
>
>
>       Log Message
>
> [dev] References to global %Conf hash were replaced with Site class accessors.
> These files are not fully replaced yet: bulk.pl, Lock.pm, wwsympa.fcgi.
> [-dev] Most of references to internal of List objects were replaced with List 
> object accessors (incomplete).
[..]
>   ## The process should not fork for sending mail
>   ## Messages will be spooled instead
> -&mail::set_send_spool($Conf{'queue'});
> +&mail::set_send_spool(Site->queue);
I'd prefer an explicit method call, for better readability:
&mail::set_send_spool(Site->queue());

>   ## Loading all Lists at startup, in order to increase execution speed
>
>
>
>         Modified: branches/db_list_cache/soap/sympasoap.pm (7923 => 7924)
>
>
> --- branches/db_list_cache/soap/sympasoap.pm    2012-11-07 17:51:06 UTC (rev 
> 7923)
> +++ branches/db_list_cache/soap/sympasoap.pm    2012-11-08 13:44:31 UTC (rev 
> 7924)
> @@ -24,7 +24,7 @@
>
>   package sympasoap;
>
> -use strict "vars";
> +use strict;
Whereas a desirable change, this has few relationship with the commit 
message... Smaller and incremental changes are easier to review and 
merge. And would avoid making thunderbird hogs with 100% cpu usage :)


--
Guillaume Rousse
INRIA, Direction des systèmes d'information
Domaine de Voluceau
Rocquencourt - BP 105
78153 Le Chesnay
Tel: 01 39 63 58 31

Attachment: smime.p7s
Description: Signature cryptographique S/MIME