Developers of Sympa

["Stefan Hornburg (Racke)" <address@concealed>]

Olivier Berger wrote:
> ping !
> 
> Is someone able to have a look at this problem (no tests needed... just
> perl reading needed ;) ?
> 
> Thanks in advance.
> 
> Le vendredi 21 septembre 2007 à 16:58 +0200, Olivier Berger a écrit :
>> Le vendredi 21 septembre 2007 à 16:29 +0200, Olivier Berger a écrit :
>>>> I'm using the soap client in Perl in which I did something like :
>>>>  $reponse = 
>>>> $soap->authenticateAndRun($user_email,$md5,'createList',['essai5','essai5','picoforge_publicproject_members','List
>>>>  essai4 of project essai4','essai4'])
>>>>     &print_result($reponse);
>>>> called with the listmaster user...
>>>>
>> Having a look at the createList() code in sympasoap.pm, I see :
>>
>> my $reject;
>>     unless ($subject) {      
>>      $reject .= 'subject'; 
>>     }
>>     unless ($template) {     
>>      $reject .= ', template'; 
>>     }
>>     unless ($description) {  
>>      $reject .= ', description'; 
>>     }
>>     unless ($topics) {       
>>      $reject .= 'topics'; 
>>     }
>>     unless ($reject){
>>      &Log::do_log('info', 'create_list %s@%s from %s refused, missing 
>> parameter(s) %s', $listname,$robot,$sender,$reject);
>>      die SOAP::Fault->faultcode('Server')
>>          ->faultstring('Missing parameter')
>>          ->faultdetail("Missing required parameter(s) : $reject");   
>>     }
>>
>> Wouldn't it be :
>>     *IF* ($reject){
>>      &Log::do_log('info', 'create_list %s@%s from %s refused, missing 
>> parameter(s) %s', $listname,$robot,$sender,$reject);
>>      die SOAP::Fault->faultcode('Server')
>>          ->faultstring('Missing parameter')
>>          ->faultdetail("Missing required parameter(s) : $reject");   
>>     }
>> instead of unless ?
>>
>> As I said, I'm not so perlist... but... with s/unless/if, I get createList 
>> to work.
>>
>> Your opinion ?

No knowledge of Perl whatsoever needed to see that the logic is wrong.

Regards
        Racke


-- 
LinuXia Systems => http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP => http://www.icdevgroup.org/
Interchange Development Team