Skip to Content.
Sympa Menu

en - [sympa-users] another, unrelated moderation bug

Subject: The mailing list for listmasters using Sympa

List archive

Chronological Thread  
  • From: Dan Pritts <address@concealed>
  • To: address@concealed
  • Subject: [sympa-users] another, unrelated moderation bug
  • Date: Mon, 21 Jun 2010 15:48:53 -0400

moderation is the bane of me today


i've discovered another moderation-related bug in 6.1b4. this
was easier to solve.

the messages sent to moderator were being line-wrapped before
being sent.

this meant that the mailto: links in the message were broken.

I fixed this in a brute force, difficult to debug, manner:

mail.pm:
275 # kludge!
276 if ( $filename =~ /moderate.tt2/ ) {
277 &do_log('info', "skipping reformat_message for moderation msg");
278 } else {
279 unless ($message = &reformat_message("$headers"."$message",
\@msgs, $data->{'charset'})) {
280 &do_log('err', "mail::mail_file: Failed to reformat
message");
281 }
282 }

I'm not sure what the better way is. Maybe extending the function
interface for the mail_file function to include a flag that lets the sender
ask to not have the content reformatted.

will submit bug in tracker

danno
--
Dan Pritts, Sr. Systems Engineer
Internet2
office: +1-734-352-4953 | mobile: +1-734-834-7224

ESCC/Internet2 Joint Techs
July 11-15, 2010 - Columbus, Ohio
http://events.internet2.edu/2010/jt-oarnet/


  • [sympa-users] another, unrelated moderation bug, Dan Pritts, 06/21/2010

Archive powered by MHonArc 2.6.19+.

Top of Page