Subject: Developers of Sympa
List archive
Re: [sympa-developpers] [sympa-commits] sympa[10744] branches/sympa-6.2-branch/src/lib/cookielib.pm: [-dev] typo.
- From: Guillaume Rousse <address@concealed>
- To: address@concealed
- Subject: Re: [sympa-developpers] [sympa-commits] sympa[10744] branches/sympa-6.2-branch/src/lib/cookielib.pm: [-dev] typo.
- Date: Wed, 28 May 2014 13:33:44 +0200
Le 26/05/2014 04:41, address@concealed a écrit :
Log Message[..]
[-dev] typo.
--- branches/sympa-6.2-branch/src/lib/cookielib.pm 2014-05-25 22:31:25That's hardly a typo, and using an explicit 'return undef' statement is even considered a wrong practice (rating 5 in perlcritic) over a raw 'return' statement (because it will return a true value in list context, for the details).
UTC (rev 10743)
+++ branches/sympa-6.2-branch/src/lib/cookielib.pm 2014-05-26 02:41:22
UTC (rev 10744)
@@ -154,7 +154,7 @@
return ($cookie->value);
}
}
- return;
+ return undef;
}
It's however more consistent with current usage in our code base.
--
Guillaume Rousse
INRIA, Direction des systèmes d'information
Domaine de Voluceau
Rocquencourt - BP 105
78153 Le Chesnay
Tel: 01 39 63 58 31
Attachment:
smime.p7s
Description: Signature cryptographique S/MIME
- Re: [sympa-developpers] [sympa-commits] sympa[10744] branches/sympa-6.2-branch/src/lib/cookielib.pm: [-dev] typo., Guillaume Rousse, 05/28/2014
Archive powered by MHonArc 2.6.19+.