Developers of Sympa

[David Verdin <address@concealed>]

Le 28/05/14 13:33, Guillaume Rousse a écrit :

address@concealed">Le 26/05/2014 04:41, address@concealed a écrit :

      Log Message

[-dev] typo.

[..]

--- branches/sympa-6.2-branch/src/lib/cookielib.pm    2014-05-25 22:31:25 UTC (rev 10743)
+++ branches/sympa-6.2-branch/src/lib/cookielib.pm    2014-05-26 02:41:22 UTC (rev 10744)
@@ -154,7 +154,7 @@
              return ($cookie->value);
          }
      }
-    return;
+    return undef;
  }

That's hardly a typo, and using an explicit 'return undef' statement is even considered a wrong practice (rating 5 in perlcritic) over a raw 'return' statement (because it will return a true value in list context, for the details).

It's however more consistent with current usage in our code base.

But don't be sad: we'll get a true error handling!

--
A bug in Sympa? Quick! To the bug tracker!

David Verdin Études et projets applicatifs
Tél : +33 2 23 23 69 71 Fax : +33 2 23 23 71 21   www.renater.fr	RENATER 263 Avenue du Gal Leclerc 35042 Rennes Cedex

Attachment: smime.p7s
Description: Signature cryptographique S/MIME