Skip to Content.
Sympa Menu

devel - Re: [sympa-dev] Easy change, big difference

Subject: Developers of Sympa

List archive

Chronological Thread  
  • From: Adam Bernstein <address@concealed>
  • To: address@concealed
  • Subject: Re: [sympa-dev] Easy change, big difference
  • Date: Sun, 17 Jul 2005 12:08:43 -0700

One more note on this one: I've realized that there was one problem, in
that the which and which_info arrays were blank (and, therefore, the
Your Lists box was blank too) the first time the home page is displayed
after logging in. It required doing a refresh or clicking on another
tab (like Help) to get it to load.

So I just had to add a few lines to populate those arrays at the end of
the do_login() subroutine. In order to make that easier, I also moved
the 20 or so lines that populate which_info into their own subroutine,
get_which_info(). This subroutine is now called from the main loop and
from do_login(), right after the three lines that populate which.

I suspect the Sympa team would already have noticed this and made a
similar change, but I can post the new diff if anyone wants it.

ab

On Wed, 2005-07-06 at 16:58 -0700, Adam Bernstein wrote:
> Now that I've (almost) merged all of our changes with the latest Sympa
> (5.1b from CVS last week), I am submitting this change that is very
> simple but makes a big difference in the usability of Sympa. With a
> simple patch to wwsympa.fcgi, very minor changes to main.tt2 and
> style.css, and one new Web template, you can have the subscriber's
> groups always listed in a box on the left-hand side, instead of on a
> separate page -- see attached .gif. This box is displayed instead of
> the list_menu whenever the list variable is not defined.
>
> The change is actually much easier in the new version, partly because of
> the better interface and partly because I'm a little smarter now than I
> was 2 years ago. I'm using the which_info parameter that you were
> already creating, except I had to add to it in wwsympa.fcgi because it
> was only showing memberships, not owners/moderators.
>
> So here's the patches:
>
> 1. Resize the menu box slightly by increasing "180px" and "190px" to
> "240px" and "250px" in style.css (there may be a cleaner way to do
> this).
>
> 2. Add one line to main.tt2 -- diff attached. I also moved one line,
> putting the language selector above the menu box, because if the user
> has many groups, the list will be long and the language selector will
> now be very far down the page. (For the same reason, I also moved the
> "Search lists" button and "RSS News" buttons to the top of the
> categories listing in home.tt2, but I had trouble with this and I'm sure
> you can do it more easily and better than I did.)
>
> 3. Remove the "Your subscriptions" line from login.tt2, as it is now
> unnecessary.
>
> 3. Add one code block of 14 lines to wwsympa.fcgi -- diff attached.
>
> 4. Create the new template your_lists.tt2, attached.
>
> I very much hope this change can make into 5.1 before it's released.
>
> Thanks!
> adam
>




Archive powered by MHonArc 2.6.19+.

Top of Page