The mailing list for listmasters using Sympa

["Chris Andrews" <address@concealed>]

I figured it out - there is a bug in the scenario evaluation code.  When determining how to evaluate the true() condition the regular _expression_ looks of the words true, any and all any where in the condition.  That means if your CustomCondition name contains "true", "any" or "all" it is evaluated as a true condition.  I put in a bug:

 

http://sourcesup.cru.fr/tracker/index.php?func=detail&aid=3306&group_id=23&atid=167

 

The code for the evaluating the true statement is:

 

    if ($condition_key =~ /\s*(true|any|all)\s*/i) {

        return $negation;

    }

 

This will find CustomConditions like:

 

CustomCondition::checkallemails

CustomCondition::isuserallowedtopost

 

etc.

 

If it is changed to match to the beginning (^) and end ($):

 

    if ($condition_key =~ /^\s*(true|any|all)\s*$/i) {

        return $negation;

    }

 

Then it will not find those custom conditions and it still properly evaluates the true() condition.

 

---

 Chris Andrews

 Boston College

 Collaboration Team

 

 

-----Original Message-----

From: Chris Andrews [mailto:address@concealed]

Sent: Monday, September 17, 2007 11:42 AM

To: address@concealed

Subject: [sympa-users] For some reason I am no longer seeing log messages

for CustomConditions

 

I do not see any log messages for the scenarios or the CustomConditions that

I have written.  I am on Sympa 5.3.3.  The log messages stopped last week

when I was messing with scenario and custom Conditions files.  I could not

get the scenarios to change - I tried the list config file touch and Sympa

restart.  I then tried the delete all the list config.bin files - it was at

that point the log message for the scenarios disappeared.  I was on Sympa

5.3a.10 at that point.  I upgrade to 5.3.3 and that did not fix the damage I

did.

 

Any ideas?

 

---

 Chris Andrews

 Boston College

 Collaboration Team

 

Attachment: smime.p7s
Description: S/MIME cryptographic signature