Skip to Content.
Sympa Menu

devel - Re: [sympa-developpers] [sympa-commits] r12749 - branches/sympa-6.2-branch/src/lib/Sympa/Spindle

Subject: Developers of Sympa

List archive

Chronological Thread  
  • From: David Verdin <address@concealed>
  • To: address@concealed
  • Subject: Re: [sympa-developpers] [sympa-commits] r12749 - branches/sympa-6.2-branch/src/lib/Sympa/Spindle
  • Date: Thu, 24 Mar 2016 14:51:34 +0100



Le 24/03/2016 05:39, address@concealed a écrit :
Author: sikeda
Date: 2016-03-24 04:39:15 +0000 (Thu, 24 Mar 2016)
New Revision: 12749

Modified:
   branches/sympa-6.2-branch/src/lib/Sympa/Spindle/DoCommand.pm
   branches/sympa-6.2-branch/src/lib/Sympa/Spindle/ProcessIncoming.pm
Log:
[-change] (r12748) DSN would be ignored only when it was sent to command addresses.  Some users might want to accept DSNs as regular posts.
Indeed. You're right once again Soji, thanks!


Modified: branches/sympa-6.2-branch/src/lib/Sympa/Spindle/DoCommand.pm
===================================================================
--- branches/sympa-6.2-branch/src/lib/Sympa/Spindle/DoCommand.pm	2016-03-23 13:14:20 UTC (rev 12748)
+++ branches/sympa-6.2-branch/src/lib/Sympa/Spindle/DoCommand.pm	2016-03-24 04:39:15 UTC (rev 12749)
@@ -66,6 +66,17 @@
 
     my $sender = $message->{'sender'};
 
+    # Preventing loops based on Sympa processes sending DSN to each other.
+    if ($message->{envelope_sender} and $message->{envelope_sender} eq '<>'
+        or grep {/multipart\/report/i} $message->get_header('Content-type')) {
+        $log->syslog(
+            'notice',
+            '%s: Ignoring message which would cause a loop; message appears to be DSN report',
+            $message
+        );
+        return undef;
+    }
+
     if ($message->{'spam_status'} eq 'spam') {
         $log->syslog(
             'notice',

Modified: branches/sympa-6.2-branch/src/lib/Sympa/Spindle/ProcessIncoming.pm
===================================================================
--- branches/sympa-6.2-branch/src/lib/Sympa/Spindle/ProcessIncoming.pm	2016-03-23 13:14:20 UTC (rev 12748)
+++ branches/sympa-6.2-branch/src/lib/Sympa/Spindle/ProcessIncoming.pm	2016-03-24 04:39:15 UTC (rev 12749)
@@ -143,14 +143,6 @@
         $message->{sender}
     );
 
-    # Preventing loops based on Sympa processes sending DSN to each other.
-    if (grep {/multipart\/report/} $message->get_header('Content-type')){
-        $log->syslog('err',
-            '%s: Ignoring message which would cause a loop; message appears to be DSN report.',
-            $message);
-        return undef;
-    }
-
     my $robot;
     my $listname;
 


--
A bug in Sympa? Quick! To the bug tracker!

 
David Verdin
Études et projets applicatifs
 
Tél : +33 2 23 23 69 71
Fax : +33 2 23 23 71 21
 
www.renater.fr
RENATER
263 Avenue du Gal Leclerc
35042 Rennes Cedex



PNG image

Attachment: smime.p7s
Description: Signature cryptographique S/MIME



  • Re: [sympa-developpers] [sympa-commits] r12749 - branches/sympa-6.2-branch/src/lib/Sympa/Spindle, David Verdin, 03/24/2016

Archive powered by MHonArc 2.6.19+.

Top of Page