Developers of Sympa

[IKEDA Soji <address@concealed>]

Hi,

On Thu, 19 Jun 2014 10:08:41 +0200
Guillaume Rousse <address@concealed> wrote:

> Le 19/06/2014 10:03, IKEDA Soji a écrit :
> > Hi,
> > 
> >> sympa[10684] trunk: [dev] rename TaskInstruction class to Instruction
> >> Revision 10684 Author rousse Date 2014-05-22 08:46:54 +0200 (jeu. 22 mai 
> >> 2014)
> >> Log Message[dev] rename TaskInstruction class to Instruction
> > 
> > Sympa::Task::Instruction or Sympa::TaskInstruction seems better for
> > me.
> Why ? We don't have any other kind of instruction.

What kind of instruction is it?

With generic name "instruction", it is difficult to know it is used
solely by Task module, and it will be problematic when someone try
to implement the other "instruction".

I prefer to former naming sense on this case.

Regards,

--- Soji

-- 
株式会社 コンバージョン  セキュリティ&OSSソリューション部   池田荘児
〒231-0004　神奈川県横浜市中区元浜町3-21-2 ヘリオス関内ビル7F
e-mail address@concealed  TEL 045-640-3550
http://www.conversion.co.jp/