Developers of Sympa

[IKEDA Soji <address@concealed>]

Hi developers,

Luke (tontonflingueur) reports that Sympa does not use File::NFSLock
properly.  Is he correct?

----
https://sourcesup.renater.fr/tracker/index.php?func=detail&aid=8711&group_id=23&atid=167

> Hello,
> 
> By working on bug [#8661] have noticed that the use of timeouts by sympa 
> 6.1.17 is incorrect on Centos 5.
> 
> The only users who will ever encounter this problems are those who have 
> lock_method 'nfs' in their sympa.conf, and I guess they are very few.
> 
> The File::NFSLock (version 1.20.2) module has two timeouts parameters:
> 
> * timeout : the regular timeouts, blocking lock will fail after this 
> period. Its value is typically a few seconds and this is what is meant by 
> the set_timeout() method of sympa's Lock.pm parameter ;
> * stale_lock_timeout : if a lock file is too old (typically half an hour), 
> it might mean that the locking process has crashed ; in that situation the 
> lock file is simply ignored.
> 
> However, in sympa, the two timeouts are somewhat mixed up : sympa uses the 
> $hold constants, fixed to 30 s as the timeout parameter, while the 
> stale_lock_timeout parameter has the value set by the set_timeout method 
> and is typically 2s, 5s or so .
> 
> Using a higher value for timeout than for stale_lock_timeout is most 
> definitely incorrect ; the two values have clearly been inverted (or the 
> File::NFSLock API has changed), and the value for the hold parameter is 
> certainly too low .
> 
> A patch is attached to this report.
> 
> Cheers,
> Luke

-- 
株式会社 コンバージョン  セキュリティ&OSSソリューション部   池田荘児
〒231-0004　神奈川県横浜市中区元浜町3-21-2 ヘリオス関内ビル7F
e-mail address@concealed  TEL 045-640-3550
http://www.conversion.co.jp/