The mailing list for listmasters using Sympa

[IKEDA Soji <address@concealed>]

Hi François,

2016/09/21 19:30、François Poulain <address@concealed> のメッセージ:

> Le Wed, 21 Sep 2016 11:06:26 +0200,
> François Poulain <address@concealed> a écrit :
> 
>> Maybe, the reply-to munging in distribute_msg should take care of the
>> existence of the X-Original-From header.
> 
> Here is a patch which works for me.

IMO X-Original-From field should not be trusted: It can be forged.
Instead, DMARC protection would be done after Reply-To munging (That's how 
Sympa 6.2 or later does).

Hope this helps,

-- Soji

> François
> 
> PS: even with a CRU account, I don't know how to fill a bug report...
> 
> --- /tmp/List.pm    2016-09-21 11:15:27.200762248 +0200
> +++ /usr/share/sympa/lib/List.pm    2016-09-21 11:35:37.950679623 +0200
> @@ -3068,6 +3068,7 @@
>     if ($self->{'admin'}{'reply_to_header'}) {
>    unless ($hdr->get('Reply-To') && 
> ($self->{'admin'}{'reply_to_header'}{'apply'} ne 'forced')) {
>        my $reply;
> +        my $from = $hdr->get('X-Original-From') ? 
> $hdr->get('X-Original-From') : $hdr->get('From');
> 
>        $hdr->delete('Reply-To');
>        $hdr->delete('Resent-Reply-To');
> @@ -3075,9 +3076,9 @@
>        if ($self->{'admin'}{'reply_to_header'}{'value'} eq 'list') {
>        $reply = "$name\@$host";
>        }elsif ($self->{'admin'}{'reply_to_header'}{'value'} eq 'sender') {
> -        $reply = $hdr->get('From');
> +        $reply = $from;
>        }elsif ($self->{'admin'}{'reply_to_header'}{'value'} eq 'all') {
> -        $reply = "$name\@$host,".$hdr->get('From');
> +        $reply = "$name\@$host,".$from;
>        }elsif ($self->{'admin'}{'reply_to_header'}{'value'} eq 
> 'other_email') {
>        $reply = $self->{'admin'}{'reply_to_header'}{'other_email'};
>        }
> 
> 
> -- 
> François Poulain <address@concealed>
> 
> L'Homme a crée Dieu a son image.
> -+- Ludwig Feuerbach, L'essence du christianisme -+-
>