Subject: Developers of Sympa
List archive
- From: Adam Bernstein <address@concealed>
- To: address@concealed
- Subject: [devel@sympa] etiquette for PRs
- Date: Thu, 27 Jun 2024 16:33:18 -0700
Soji et al. -
We've got a big list of fixes and improvements to submit, and have already done a couple, but I want to be sure I'm doing things the best possible way to make things easiest for you. I'm just learning the modern development and Github process, so this is probably all very basic and possibly annoying, but I'm trying to be good!
So a couple of questions:
1. If we have a PR to submit, should we create an issue first, or just go straight to the PR?
2. I know the PR should be from a custom branch on my own fork of the sympa repo, but am I correct that each PR should also be *on its own new branch* within my fork? Or should they all just be separate commits within the same branch? Or does that matter at all?
3. And finally... anything other tips you want to provide, or comments on things I did badly on my previous PR (https://github.com/sympa-community/sympa/pull/1849)?
Thanks much for your time!
adam
--
Adam Bernstein (he/him)
Electric Embers Cooperative
Handcrafted hosting, powering the fires of change
electricembers.coop
(415) 992-6916
- [devel@sympa] etiquette for PRs, Adam Bernstein, 06/27/2024
Archive powered by MHonArc 2.6.19+.