Developers of Sympa

[Philip Crandall <address@concealed>]

Here is the patch for Sympa 5.

Cheers,
Philip

On Tue, 2009-06-23 at 16:41 -0500, Philip Crandall wrote:
> For feature request
> http://sourcesup.cru.fr/tracker/?group_id=23&atid=170&func=detail&aid=3802 
> I've made a patch for Sympa 6.0b1.  I've tested the patch and everything 
> seems to work correctly.  I made the parameter available to robot.conf as 
> well.
> 
> I can work up a patch for v5 as well.
> 
> I'd be happy to attach it to the open feature request, but I don't seem
> to have the ability to do so.
> 
> Cheers,
> 
> Philip Crandall
> University of Chicago
> 
> On Fri, 2009-06-19 at 11:40 -0500, Philip Crandall wrote:
> > I agree that it would be nice to have as a variable that exists in 
> > sympa.conf/robot.conf (maybe as 'gecos').  I set this globally by using a 
> > perl command in your /home/sympa/[bin/]etc/mail_tt2/ directory:
> > 
> > > perl -p -i.old -e 's/^From: SYMPA(.*)/From: My Service\1/g' *.tt2
> > 
> > A patch looks fairly straight-forward.  You would need to add the 
> > sympa.conf/robot.conf variable to Conf.pm.  There is also an edit 
> > required to List.pm in sub send_file (around line 3190) to make the 
> > 'gecos' variable available to the templates.  You could then run the same 
> > perl script on the template files, but it would be like:
> > 
> > > perl -p -i.old -e 's/^From: SYMPA(.*)/From: \[% conf.gecos %\]\1/g' 
> > > *.tt2
> > 
> > Hope that helps.  If I get a chance, I'll submit a patch upstream for it.
> > 
> > Cheers,
> > Philip Crandall
> > University of Chicago
> > 
> > > -----Original Message-----
> > > From: Simon Taylor [mailto:address@concealed]
> > > Sent: Thursday, June 18, 2009 11:21 PM
> > > To: Jobst Schmalenbach
> > > Cc: address@concealed; address@concealed
> > > Subject: Re: [sympa-users] SYMPA "from" name
> > > 
> > > 
> > > > But if it comes from "Barrett ListServer" (in my case) it would be
> > > obvious what that means, especially if you entered your email address
> > > into a subscription box 10 minutes earlier!
> > > >
> > > > The 1600 odd people that are subscribed to one of our lists contain
> > > Managers, sales people, HR and so on and I had a few people having had
> > > some troubles due to their low knowledge.
> > > 
> > > We have a similar problem. It would be nice if the name was
> > > configurable.
> > > 
> > > Cheers,
> > > 
> > > Simon Taylor
> > > 
> > > P.S. Over 40 but a geek ;-)
> > > 
> > 
> > 
-- 
Philip Crandall <address@concealed>
NSIT NBS University of Chicago
diff -bBruN ./sympa-5.4/mail_tt2/certif_warning.tt2 ./sympa-5.4-dev/mail_tt2/certif_warning.tt2
--- ./sympa-5.4/mail_tt2/certif_warning.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/certif_warning.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 Subject: [% FILTER qencode %][%|loc%]near expiration of your certificate[%END%][%END%]
 
 [%|loc(expiration_date)%]Your authentification certificate will expire on %1.[%END%]
diff -bBruN ./sympa-5.4/mail_tt2/command_report.tt2 ./sympa-5.4-dev/mail_tt2/command_report.tt2
--- ./sympa-5.4/mail_tt2/command_report.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/command_report.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 To: [% to %]
 Subject: [% FILTER qencode %][%|loc%]Results of your commands[%END%][%END%]
 X-Loop: [% conf.sympa %]
diff -bBruN ./sympa-5.4/mail_tt2/global_remind.tt2 ./sympa-5.4-dev/mail_tt2/global_remind.tt2
--- ./sympa-5.4/mail_tt2/global_remind.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/global_remind.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 Subject: [% FILTER qencode %][%|loc%]Subscription summary[%END%][%END%]
 
 [%|loc(user.email)%]Summary of your subscription (using the e-mail %1).[%END%]
diff -bBruN ./sympa-5.4/mail_tt2/helpfile.tt2 ./sympa-5.4-dev/mail_tt2/helpfile.tt2
--- ./sympa-5.4/mail_tt2/helpfile.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/helpfile.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 Subject: [% FILTER qencode %][%|loc%]User guide[%END%][%END%]
 
               SYMPA -- Systeme de Multi-Postage Automatique
diff -bBruN ./sympa-5.4/mail_tt2/index_archive.tt2 ./sympa-5.4-dev/mail_tt2/index_archive.tt2
--- ./sympa-5.4/mail_tt2/index_archive.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/index_archive.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 Subject: [% FILTER qencode %][%|loc(list.name)%]Archives index of list %1[%END%][%END%]
 
 [% FOREACH a = archives -%]
diff -bBruN ./sympa-5.4/mail_tt2/list_created.tt2 ./sympa-5.4-dev/mail_tt2/list_created.tt2
--- ./sympa-5.4/mail_tt2/list_created.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/list_created.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 Subject: [% FILTER qencode %][%|loc(list.name)%]%1 mailing list creation[%END%][%END%]
 
 [%|loc(list.name,list.host)%]%1@%2 mailing list has been activated by listmaster.[%END%]
diff -bBruN ./sympa-5.4/mail_tt2/listeditor_notification.tt2 ./sympa-5.4-dev/mail_tt2/listeditor_notification.tt2
--- ./sympa-5.4/mail_tt2/listeditor_notification.tt2	2007-03-30 07:19:37.000000000 -0500
+++ ./sympa-5.4-dev/mail_tt2/listeditor_notification.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 To: [% to %]
 [% IF type == 'shared_moderated' -%]
 Subject: [% FILTER qencode %][%|loc(list.name)%]Shared document to be approved for %1[%END%][%END%]
diff -bBruN ./sympa-5.4/mail_tt2/listmaster_notification.tt2 ./sympa-5.4-dev/mail_tt2/listmaster_notification.tt2
--- ./sympa-5.4/mail_tt2/listmaster_notification.tt2	2008-01-09 02:01:55.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/listmaster_notification.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 To: [% FILTER qencode %][%|loc%]Listmaster[%END%] <[% to %]>[%END%]
 [% IF type == 'request_list_creation' -%]
 Subject: [% FILTER qencode %][%|loc(list.name)%]List "%1" creation request[%END%][%END%]
diff -bBruN ./sympa-5.4/mail_tt2/listowner_notification.tt2 ./sympa-5.4-dev/mail_tt2/listowner_notification.tt2
--- ./sympa-5.4/mail_tt2/listowner_notification.tt2	2008-01-22 04:08:52.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/listowner_notification.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 To: [% to %]
 [% IF type == 'arc_quota_exceeded' -%]
 Subject: [% FILTER qencode %][%|loc(list.name)%]List %1 archive quota exceeded[%END%][%END%]
diff -bBruN ./sympa-5.4/mail_tt2/list_rejected.tt2 ./sympa-5.4-dev/mail_tt2/list_rejected.tt2
--- ./sympa-5.4/mail_tt2/list_rejected.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/list_rejected.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 Subject: [% FILTER qencode %][% list.name %][%END%]
 
 [%|loc(list.name,list.host)%]%1@%2 mailing list has been rejected by listmaster.[%END%]
diff -bBruN ./sympa-5.4/mail_tt2/lists.tt2 ./sympa-5.4-dev/mail_tt2/lists.tt2
--- ./sympa-5.4/mail_tt2/lists.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/lists.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 Subject: [% FILTER qencode %][%|loc%]Public lists[%END%][%END%]
 
 [%|loc(conf.email,conf.host)%]Here is the list of lists from %1@%2[%END%]
diff -bBruN ./sympa-5.4/mail_tt2/list_unknown.tt2 ./sympa-5.4-dev/mail_tt2/list_unknown.tt2
--- ./sympa-5.4/mail_tt2/list_unknown.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/list_unknown.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 To: [% to %]
 Subject: [% FILTER qencode %][%|loc%]List unknown[%END%][%END%]
 Content-Type: multipart/report; report-type=delivery-status; 
diff -bBruN ./sympa-5.4/mail_tt2/message_report.tt2 ./sympa-5.4-dev/mail_tt2/message_report.tt2
--- ./sympa-5.4/mail_tt2/message_report.tt2	2007-12-14 09:39:27.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/message_report.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 To: [% to %]
 [% IF type == 'intern_error' -%]
 Subject: [% FILTER qencode %][%|loc%]Message distribution : Internal server error[%END%][%END%]
diff -bBruN ./sympa-5.4/mail_tt2/request_auth.tt2 ./sympa-5.4-dev/mail_tt2/request_auth.tt2
--- ./sympa-5.4/mail_tt2/request_auth.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/request_auth.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 To: [% to %]
 Subject: [% FILTER qencode %][%command%][%END%]
 
diff -bBruN ./sympa-5.4/mail_tt2/sendpasswd.tt2 ./sympa-5.4-dev/mail_tt2/sendpasswd.tt2
--- ./sympa-5.4/mail_tt2/sendpasswd.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/sendpasswd.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 To: [% newuser.email %]
 [% IF action == 'subrequest' -%]
 Subject: [% FILTER qencode %][%|loc(conf.title,list)%]%1 / subscribing to %2[%END%][%END%]
diff -bBruN ./sympa-5.4/mail_tt2/user_notification.tt2 ./sympa-5.4-dev/mail_tt2/user_notification.tt2
--- ./sympa-5.4/mail_tt2/user_notification.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/user_notification.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 To: [% to %]
 [% IF type == 'auto_notify_bouncers' -%]
 Subject: [% FILTER qencode %][%|loc(list.name)%]Your bouncing address in list %1[%END%][%END%]
diff -bBruN ./sympa-5.4/mail_tt2/which.tt2 ./sympa-5.4-dev/mail_tt2/which.tt2
--- ./sympa-5.4/mail_tt2/which.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/which.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 Subject: [% FILTER qencode %][%|loc%]Result of your command[%END%][%END%]
 
 [%|loc%]Here are the lists you are currently subscribed to :[%END%]
diff -bBruN ./sympa-5.4/mail_tt2/your_infected_msg.tt2 ./sympa-5.4-dev/mail_tt2/your_infected_msg.tt2
--- ./sympa-5.4/mail_tt2/your_infected_msg.tt2	2007-02-05 08:54:15.000000000 -0600
+++ ./sympa-5.4-dev/mail_tt2/your_infected_msg.tt2	2009-06-24 11:43:57.000000000 -0500
@@ -1,4 +1,4 @@
-From: SYMPA <[% conf.email %]@[% conf.host %]>
+From: [% conf.email_gecos %] <[% conf.email %]@[% conf.host %]>
 Subject: [% FILTER qencode %][%|loc%]A virus in your email[%END%][%END%]
 
     [%|loc%]***** V I R U S    A L E R T *****[%END%]
diff -bBruN ./sympa-5.4/src/Conf.pm ./sympa-5.4-dev/src/Conf.pm
--- ./sympa-5.4/src/Conf.pm	2009-03-30 08:31:10.000000000 -0500
+++ ./sympa-5.4-dev/src/Conf.pm	2009-06-24 11:43:10.000000000 -0500
@@ -49,7 +49,7 @@
 		       clean_delay_queue clean_delay_queueauth clean_delay_queuemod clean_delay_queuesubscribe clean_delay_queueautomatic clean_delay_queuetopic clean_delay_queuebounce clean_delay_queueother clean_delay_queueoutgoing clean_delay_tmpdir default_remind_task
 		       cookie cookie_cas_expire create_list automatic_list_feature automatic_list_creation automatic_list_removal crl_dir crl_update_task db_host db_env db_name db_timeout
 		       db_options db_passwd db_type db_user db_port db_additional_subscriber_fields db_additional_user_fields
-		       default_shared_quota default_archive_quota default_list_priority distribution_mode edit_list email etc
+		       default_shared_quota default_archive_quota default_list_priority distribution_mode edit_list email email_gecos etc
 		       global_remind home host ignore_x_no_archive_header_feature domain lang listmaster listmaster_email localedir log_socket_type log_level 
 		       logo_html_definition logs_expiration_period
                        main_menu_custom_button_1_title main_menu_custom_button_1_url main_menu_custom_button_1_target 
@@ -110,6 +110,7 @@
      'host'    => undef,
      'domain'  => undef,
      'email'   => 'sympa',
+     'email_gecos' => 'SYMPA',
      'pidfile' => '--PIDDIR--/sympa.pid',
      'pidfile_distribute' => '--PIDDIR--/sympa-distribute.pid',
      'pidfile_creation' => '--PIDDIR--/sympa-creation.pid',
@@ -552,6 +553,7 @@
 				  'allow_subscribe_if_pending'   => 1,
 				  listmaster      => 1,
 				  email           => 1,
+                                  email_gecos	  => 1,
 				  host            => 1,
 				  wwsympa_url     => 1,
 				  'title'         => 1,
@@ -667,6 +669,7 @@
 
 	$robot_conf->{$robot}{'lang'} ||= $Conf{'lang'};
 	$robot_conf->{$robot}{'email'} ||= $Conf{'email'};
+        $robot_conf->{$robot}{'email_gecos'} ||= $Conf{'email_gecos'};
 	$robot_conf->{$robot}{'log_smtp'} ||= $Conf{'log_smtp'};
 	$robot_conf->{$robot}{'log_level'} ||= $Conf{'log_level'};
 	$robot_conf->{$robot}{'wwsympa_url'} ||= 'http://'.$robot_conf->{$robot}{'http_host'}.'/sympa';
diff -bBruN ./sympa-5.4/src/List.pm ./sympa-5.4-dev/src/List.pm
--- ./sympa-5.4/src/List.pm	2009-02-16 07:30:38.000000000 -0600
+++ ./sympa-5.4-dev/src/List.pm	2009-06-24 11:38:13.000000000 -0500
@@ -3019,7 +3019,7 @@
 	&tt2::add_include_path($d);
     }
 
-    foreach my $p ('email','host','sympa','request','listmaster','wwsympa_url','title','listmaster_email') {
+    foreach my $p ('email','email_gecos','host','sympa','request','listmaster','wwsympa_url','title','listmaster_email') {
 	$data->{'conf'}{$p} = &Conf::get_robot_conf($robot, $p);
     }
 
diff -bBruN ./sympa-5.4/src/sympa_wizard.pl ./sympa-5.4-dev/src/sympa_wizard.pl
--- ./sympa-5.4/src/sympa_wizard.pl	2009-03-30 08:31:10.000000000 -0500
+++ ./sympa-5.4-dev/src/sympa_wizard.pl	2009-06-24 11:34:19.000000000 -0500
@@ -180,6 +180,12 @@
 	       'file' => 'sympa.conf',
 	       'advice' =>"Effective address will be \[EMAIL\]@\[HOST\]"},
 
+	      {'name' => 'email_gecos',
+	       'default' => 'SYMPA',
+	       'query' => 'Gecos for email parameter',
+	       'file' => 'sympa.conf',
+	       'advice' =>"This parameter will be used in the web_tt2 files."},
+
 	      {'name' => 'create_list',
 	       'default' => 'public_listmaster',
 	       'query' => 'Who is able to create lists',

Attachment: smime.p7s
Description: S/MIME cryptographic signature