Skip to Content.
Sympa Menu

devel - Re: [sympa-dev] Is a lock need for /stats ?

Subject: Developers of Sympa

List archive

Chronological Thread  
  • From: Kazuo Moriwaka <address@concealed>
  • To: address@concealed
  • Cc: address@concealed
  • Subject: Re: [sympa-dev] Is a lock need for /stats ?
  • Date: Tue, 16 Aug 2005 13:35:22 +0900 (JST)

Hello,

I fixed my NFS-aware lock patch again.
Following patch add check for that $lock is defined or not.
undefined $lock cause internal server error.

I don't find a point which call unlock() with invalid filehandle or
call it twice, but it causes some errors in my test environment.

regards,
--
Kazuo Moriwaka <address@concealed>

--- src/tools.pl
+++ src/tools.pl
@@ -2052,7 +2052,7 @@
my $lock = $locks{$fh};
delete $locks{$fh};

- unless ($lock->unlock) {
+ unless (defined $lock and $lock->unlock) {
&do_log('err', 'Failed UNlocking %s: %s', $lock_file, $!);
return undef;
}



  • Re: [sympa-dev] Is a lock need for /stats ?, Kazuo Moriwaka, 08/16/2005

Archive powered by MHonArc 2.6.19+.

Top of Page